Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): add model to generic Weather client #5213

Closed

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 13, 2023

Issue

Issue number, if available, prefixed with "#"

Edge case: services with no models are broken, since the models_*.ts files need at least one export statement to be considered a module.

Description

What does this implement/fix? Explain your changes.

Add model to generic Weather client.

Testing

How was this change tested?

cd codegen/ && ./gradlew :generic-client-test-codegen:clean :generic-client-test-codegen:build

Additional context

Add any other context about the PR here.

Bug first found in: #5212


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall marked this pull request as ready for review September 13, 2023 22:03
@syall syall requested a review from a team as a code owner September 13, 2023 22:03
@syall syall closed this Sep 13, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants