Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): update smithy-typescript commit #5191

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 7, 2023

Issue

Issue number, if available, prefixed with "#"

N/A.

Description

What does this implement/fix? Explain your changes.

Bump smithy-typescript commit to smithy-lang/smithy-typescript@8e23b1b.

Dependent on:

Testing

How was this change tested?

  1. Change config.js to point to 8e23b1b1df60d81ae58a93998228a8a60a72cc93
  2. Run yarn generate-clients
  3. Run node scripts/runtime-dependency-version-check/runtime-dep-version-check.js
  4. Run yarn
  5. Run yarn build:all
  6. PR CI passes

Observed codegen changes: HttpHandlerExtensionConfiguration is now added to each client in:

  • extensionConfiguration.ts
diff --git a/clients/client-accessanalyzer/src/extensionConfiguration.ts b/clients/client-accessanalyzer/src/extensionConfiguration.ts
index 6d8fbc43442..660d1c6fbfe 100644
--- a/clients/client-accessanalyzer/src/extensionConfiguration.ts
+++ b/clients/client-accessanalyzer/src/extensionConfiguration.ts
@@ -1,7 +1,10 @@
 // smithy-typescript generated code
+import { HttpHandlerExtensionConfiguration } from "@smithy/protocol-http";
 import { DefaultExtensionConfiguration } from "@smithy/types";
 
 /**
  * @internal
  */
-export interface AccessAnalyzerExtensionConfiguration extends DefaultExtensionConfiguration {}
+export interface AccessAnalyzerExtensionConfiguration
+  extends HttpHandlerExtensionConfiguration,
+    DefaultExtensionConfiguration {}
  • runtimeExtensions.ts
diff --git a/clients/client-accessanalyzer/src/runtimeExtensions.ts b/clients/client-accessanalyzer/src/runtimeExtensions.ts
index 52162c3f77b..df73513b2eb 100644
--- a/clients/client-accessanalyzer/src/runtimeExtensions.ts
+++ b/clients/client-accessanalyzer/src/runtimeExtensions.ts
@@ -1,4 +1,5 @@
 // smithy-typescript generated code
+import { getHttpHandlerExtensionConfiguration, resolveHttpHandlerRuntimeConfig } from "@smithy/protocol-http";
 import { getDefaultExtensionConfiguration, resolveDefaultRuntimeConfig } from "@smithy/smithy-client";
 
 import { AccessAnalyzerExtensionConfiguration } from "./extensionConfiguration";
@@ -7,7 +8,7 @@ import { AccessAnalyzerExtensionConfiguration } from "./extensionConfiguration";
  * @public
  */
 export interface RuntimeExtension {
-  configure(clientConfiguration: AccessAnalyzerExtensionConfiguration): void;
+  configure(extensionConfiguration: AccessAnalyzerExtensionConfiguration): void;
 }
 
 /**
@@ -25,6 +26,7 @@ const asPartial = <T extends Partial<AccessAnalyzerExtensionConfiguration>>(t: T
 export const resolveRuntimeExtensions = (runtimeConfig: any, extensions: RuntimeExtension[]) => {
   const extensionConfiguration: AccessAnalyzerExtensionConfiguration = {
     ...asPartial(getDefaultExtensionConfiguration(runtimeConfig)),
+    ...asPartial(getHttpHandlerExtensionConfiguration(runtimeConfig)),
   };
 
   extensions.forEach((extension) => extension.configure(extensionConfiguration));
@@ -32,5 +34,6 @@ export const resolveRuntimeExtensions = (runtimeConfig: any, extensions: Runtime
   return {
     ...runtimeConfig,
     ...resolveDefaultRuntimeConfig(extensionConfiguration),
+    ...resolveHttpHandlerRuntimeConfig(extensionConfiguration),
   };
 };

Additional context

Add any other context about the PR here.

N/A.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall force-pushed the bump-smithy-typescript-commit branch 4 times, most recently from 6f92d8d to 2d44b01 Compare September 7, 2023 22:24
@syall syall marked this pull request as ready for review September 7, 2023 22:28
@syall syall requested review from a team as code owners September 7, 2023 22:28
@syall syall marked this pull request as draft September 8, 2023 01:30
@syall syall force-pushed the bump-smithy-typescript-commit branch 3 times, most recently from d5e1134 to e958bfd Compare September 8, 2023 16:24
@syall syall force-pushed the bump-smithy-typescript-commit branch from e958bfd to 6a12867 Compare September 8, 2023 20:13
@syall syall marked this pull request as ready for review September 8, 2023 20:15
@syall syall merged commit d058d78 into aws:main Sep 8, 2023
3 checks passed
@syall syall deleted the bump-smithy-typescript-commit branch September 8, 2023 21:04
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants