chore(packages): re-export types from @smithy/types #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Jul 5, 2023
| @@ -41,6 +41,7 @@ | |||
| "directory": "packages/types" | |||
| }, | |||
| "dependencies": { | |||
| "@smithy/types": "1.1.0", | |||
There was a problem hiding this comment.
shouldn't this be "@smithy/types": "^1.0.0", to match client codegen?
There was a problem hiding this comment.
Client codegen should be on "^1.1.0" also. Fixed here: #4926
kuhe
approved these changes
Jul 10, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
This updates the
@aws-sdk/typespackage to re-export types that have been migrated to @smithy/types.Testing
Ran
yarn && yarn build:all.Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.