Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): automatic blob type conversions #4836

Merged
merged 5 commits into from Jun 20, 2023
Merged

feat(clients): automatic blob type conversions #4836

merged 5 commits into from Jun 20, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jun 13, 2023 •
edited

Issue

codegen for smithy-lang/smithy-typescript#777
closes #2123
closes #4786

Description

see smithy-lang/smithy-typescript#777

Testing

  • write e2e test suite
  • create test echo lambda
  • check all new blobtypes can be input to payload blob e.g. Lambda invoke
  • check output of payload blob is wrapped in adapter, and can be transformed to string
  • existing unit, integration, e2e tests passing

@kuhe kuhe mentioned this pull request Jun 13, 2023
Merged
1 task
@kuhe kuhe force-pushed the feat/blobs branch 4 times, most recently from 416285e to a7df06d Compare June 15, 2023 17:00
@kuhe kuhe mentioned this pull request Jun 15, 2023
Closed
1 task
@kuhe
Copy link
Contributor Author

kuhe commented Jun 15, 2023 

....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

149 scenarios (149 passed)
492 steps (492 passed)

@kuhe kuhe force-pushed the feat/blobs branch 2 times, most recently from 656c85d to d20874b Compare June 15, 2023 18:51
@kuhe kuhe changed the base branch from main to feat/blobs June 15, 2023 18:52
@kuhe kuhe changed the base branch from feat/blobs to main June 15, 2023 18:53
@kuhe kuhe marked this pull request as ready for review June 15, 2023 19:44
@kuhe kuhe requested review from a team as code owners June 15, 2023 19:44
@kuhe kuhe force-pushed the feat/blobs branch 3 times, most recently from 488b2f9 to 7adc88f Compare June 16, 2023 20:16
@kuhe kuhe force-pushed the feat/blobs branch 2 times, most recently from 281f4c6 to 6ebe932 Compare June 16, 2023 21:10
@kuhe kuhe merged commit 60ec921 into aws:main Jun 20, 2023
3 checks passed
@kuhe kuhe deleted the feat/blobs branch June 20, 2023 23:49
@srchase srchase mentioned this pull request Jun 22, 2023
Merged
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

@milesziemer milesziemer milesziemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kuhe @trivikr @milesziemer