Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(a11y): update badge text to an exact match of content #4655

Merged
merged 3 commits into from
Apr 24, 2023
Merged

docs(a11y): update badge text to an exact match of content #4655

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93eaa25
docs(preview): add preview to README
MYoung25 Apr 24, 2023
b318325
Merge branch 'main' of github.com:myoung25/aws-sdk-js-v3
MYoung25 Apr 24, 2023
ea1313b
docs(a11y): update badge text to an exact match of content
MYoung25 Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/core-theme-documentation-generator/src/theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class SdkThemeContext extends DefaultThemeRenderContext {
return res.json()
})
.then(({ version }) => {
versionEl.alt = "NPM latest version V" + version
versionEl.alt = "npm@latest v" + version
})
.catch(err => {
console.error(err)
Expand Down Expand Up @@ -286,8 +286,10 @@ class SdkThemeContext extends DefaultThemeRenderContext {
<div class="documentation-developer-preview">
<h2>New API Documentation - Developer Preview Available</h2>
<p>
We are excited to announce the <a href="https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/">developer preview</a> of our new API documentation
for AWS SDK for JavaScript v3. Please follow instructions on the landing page to leave us your feedback.
We are excited to announce the{" "}
<a href="https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/">developer preview</a> of our new
API documentation for AWS SDK for JavaScript v3. Please follow instructions on the landing page to leave
us your feedback.
</p>
</div>
{oldHeader(props)}
Expand Down