Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misaligned struct member used in atomic operation #2519

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix misaligned struct member used in atomic operation #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce573ee
Fix misaligned struct member used in atomic operation
dswarbrick Feb 27, 2024
02ed7d5
changelog
lucix-aws Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/448aaf1509f448d385e5c243933a39d8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "448aaf15-09f4-48d3-85e5-c243933a39d8",
"type": "bugfix",
"description": "Fix misaligned struct member used in atomic operation. This fixes a panic caused by attempting to atomically access a struct member which is not 64-bit aligned when running on 32-bit arch, due to the smaller sync.Map struct.",
"modules": [
"service/internal/endpoint-discovery"
]
}
6 changes: 3 additions & 3 deletions service/internal/endpoint-discovery/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import (
// based on some key. The data structure makes use of a read write
// mutex to enable asynchronous use.
type EndpointCache struct {
endpoints sync.Map
endpointLimit int64
// size is used to count the number elements in the cache.
// The atomic package is used to ensure this size is accurate when
// using multiple goroutines.
size int64
size int64
endpoints sync.Map
endpointLimit int64
}

// NewEndpointCache will return a newly initialized cache with a limit
Expand Down