Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid defaults from a few services #2458

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Remove invalid defaults from a few services #2458

merged 2 commits into from
Jan 18, 2024

Commits on Jan 16, 2024

  1. Remove invalid defaults from a few services 

    Updates the RemoveDefaults customization to include a few more services/
shapes, specifically ones where the shape has a range incompatible with
its default value. Also refactors RemoveDefaults slightly.

Tested by `make generate` and confirming the expected diff.

This is a breakfix for evidently and emrserverless - the types for
ResultsPeriod and WorkerCounts will become nillable.
    @milesziemer
    milesziemer committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0c0e5b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. add changelogs

    @lucix-aws
    lucix-aws committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d395eeb View commit details
    Browse the repository at this point in the history