Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: S3 HeadObject NotFound error never being returned #2139

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix: S3 HeadObject NotFound error never being returned #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c368c41
remove s3 HeadObject customization that strips errors
aajtodd May 25, 2023
e335331
add changelog
aajtodd May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changelog/d9de6f3dd7c146c9966648ecda1fa2a8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "d9de6f3d-d7c1-46c9-9666-48ecda1fa2a8",
"type": "bugfix",
"description": "Fix HeadObject to return types.Nound when an object does not exist. Fixes [2084](https://github.com/aws/aws-sdk-go-v2/issues/2084)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types.Nound 🤔 should be types.NotFound?

"modules": [
"service/s3"
]
}
45 changes: 0 additions & 45 deletions .../java/software/amazon/smithy/aws/go/codegen/customization/S3HeadObjectCustomizations.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...n/resources/META-INF/services/software.amazon.smithy.go.codegen.integration.GoIntegration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ software.amazon.smithy.aws.go.codegen.customization.S3AcceptEncodingGzip
software.amazon.smithy.aws.go.codegen.customization.KinesisCustomizations
software.amazon.smithy.aws.go.codegen.customization.S3ErrorWith200Status
software.amazon.smithy.aws.go.codegen.customization.Route53Customizations
software.amazon.smithy.aws.go.codegen.customization.S3HeadObjectCustomizations
software.amazon.smithy.aws.go.codegen.customization.PresignURLAutoFill
software.amazon.smithy.aws.go.codegen.customization.S3ExportInternalFeatures
software.amazon.smithy.aws.go.codegen.customization.S3ControlEndpointResolver
Expand Down
19 changes: 4 additions & 15 deletions service/s3/api_op_HeadObject.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions service/s3/deserializers.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.