Fix misaligned struct member used in atomic operation #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw when this came in yesterday, solid find. I was actually planning on adding a 386 arch test in CI as you've called out there, I'll try and add that to this changeset when I get capacity. |
lucix-aws
approved these changes
Feb 27, 2024
wty-Bryant
approved these changes
Mar 1, 2024
Merged
This fixes a panic caused by attempting to atomically access a struct member which is not 64-bit aligned when running on 32-bit arch, due to the smaller sync.Map struct. Fixes: #2518 Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>
lucix-aws
force-pushed
the
fix-unaligned-atomic
branch
from
0f15348
to
02ed7d5
Compare
|
Added the x86 test externally and rebased this branch. Test running now, will merge on a pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic caused by attempting to atomically access a struct member which is not 64-bit aligned when running on 32-bit arch, due to the smaller sync.Map struct.
Fixes: #2518
Please consider adding testing with a 32-bit GOARCH (e.g. "386") to your CI testing pipeline to avoid such oversights in future.