Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integ-tests-3.6.0] Pin pytest version to 7.3 #5428

Merged
merged 1 commit into from Jun 26, 2023

Conversation

lukeseawalker
Copy link
Contributor

Description of changes

pytest 7.4.0 breaks the possibility to add custom options to pytest. Tests are failing with:

ERROR: usage: test_runner.py [options] [file_or_dir] [file_or_dir] [...]

test_runner.py: error: unrecognized arguments: --tests-log-file=...log --output-dir=.../eu-north-1 --key-name=... --key-path=...

Tests

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

References

  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pytest 7.4.0 breaks the possibility to add custom options to pytest.
Tests are failing with:

```
ERROR: usage: test_runner.py [options] [file_or_dir] [file_or_dir] [...]

test_runner.py: error: unrecognized arguments: --tests-log-file=...log --output-dir=.../eu-north-1 --key-name=... --key-path=...
```

Signed-off-by: Enrico Usai <usai@amazon.com>
@lukeseawalker lukeseawalker requested review from a team as code owners June 23, 2023 14:47
@lukeseawalker lukeseawalker added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #5428 (3046a33) into integ-tests-3.6.0 (38d18c6) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           integ-tests-3.6.0    #5428   +/-   ##
==================================================
  Coverage              89.73%   89.73%           
==================================================
  Files                    175      175           
  Lines                  15224    15224           
==================================================
  Hits                   13661    13661           
  Misses                  1563     1563           
Flag Coverage Δ
unittests 89.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mdmintz
Copy link

mdmintz commented Jun 23, 2023

This was due to pytest-dev/pytest#11043
You may have to change the location of the rootdir via --rootdir=DIR, as referenced here: pytest-dev/pytest#11134 (comment) in order to safely migrate to pytest 7.4.0.

@lukeseawalker lukeseawalker merged commit 67aaca8 into aws:integ-tests-3.6.0 Jun 26, 2023
26 of 27 checks passed
@lukeseawalker
Copy link
Contributor Author

thank you @mdmintz, we will consider that for the develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants