-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generated bindings for aws-lc-fips-sys v0.12.6 #372
Auto-generated bindings for aws-lc-fips-sys v0.12.6 #372
Conversation
b9b5090
to
fd1befa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 60 60
Lines 7865 7865
=======================================
Hits 7537 7537
Misses 328 328 ☔ View full report in Codecov by Sentry. |
fd1befa
to
90f2b48
Compare
90f2b48
to
de3112b
Compare
Is there a reason for this documented somewhere? In general static builds are fairly idiomatic for Rust so this sounds surprising to me. Instead of conditioning on musl I'd probably recommend crt-static target feature (see https://rust-lang.github.io/rfcs/1721-crt-static.html for some docs), that is probably more in line with matching libc linkage across lots of platforms. (Note that there's a long-standing ask from musl upstream that Rust stops statically linking by default, since that's not what you want on musl distros like Alpine). |
There are a few reasons for this that are fairly specific to "FIPS":
Thus, we can perform the shared build of the FIPS modules across many more platforms than we can with static, and the shared build is less likely to be affected by LTO. |
Default to 'shared' FIPS build
de3112b
to
3e70628
Compare
To avoid potentially breaking downstream builds/deployment, the default build of |
Description of changes:
aws-lc-fips-sys
to 0.12.6 to align with AWS-LC-FIPS 2.0.9aws-lc-fips-sys
.Testing:
Bindings generated by this workflow run: https://github.com/aws/aws-lc-rs/actions/runs/8346539433
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.