Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for sys crate publish; Script cleanup #351

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

  • Add check to sys-crate publishing script to verify expected prefix.
  • Fix how generation scripts check for macOS.
  • Remove generation script expectation that we're on main.
  • Other cleanup in generation scripts.

Testing:

Tested on macos and linux hosts

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner February 16, 2024 16:58
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (8a6facc) to head (f63b039).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          60       60           
  Lines        7865     7865           
=======================================
  Hits         7537     7537           
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the script-cleanup branch 2 times, most recently from 07e419b to df1a3cf Compare February 16, 2024 19:27
@justsmth justsmth force-pushed the script-cleanup branch 4 times, most recently from 2abc8e1 to 51970e9 Compare February 26, 2024 16:59
@smittals2 smittals2 self-requested a review February 29, 2024 21:35
smittals2
smittals2 previously approved these changes Feb 29, 2024
skmcgrail
skmcgrail previously approved these changes Mar 14, 2024
samuel40791765
samuel40791765 previously approved these changes Mar 14, 2024
@justsmth justsmth dismissed stale reviews from samuel40791765 and skmcgrail via 7f7c6a3 March 14, 2024 18:51
@justsmth justsmth merged commit 0152e5b into aws:main Mar 14, 2024
148 of 154 checks passed
@justsmth justsmth deleted the script-cleanup branch March 14, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants