Marshall IHttpRequestFeature.RawTarget #1463
Merged
+583
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
approved these changes
Mar 24, 2023
|
Version 8.1.0 of Amazon.Lambda.AspNetCoreServer has been released with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
HttpRequest.PathandHttpRequest.PathBaseproperties contain unescaped representations of the request path; however, it is sometimes useful to have access to the raw (escaped) request path as supplied exactly by the caller. Due to inconsistencies in URL escaping rules (that is, which characters are considered necessary to escape) and to the fact that thePathStringtype contains a partial unescaping, it is not possible to reconstruct the original, raw request path from thePathandPathBaseproperties.The
RawTargetproperty exists on theIHttpRequestFeatureinterface to address the above issue; however, that property is currently not set during request marshalling. This PR updates theMarshallRequestimplementations to set theIHttpRequestFeature.RawTargetproperty.All existing unit tests pass and new unit tests have been added to verify new functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.