Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticloadbalancingv2): dualstack ALB missing default IPv6 ingress rule #8798

Merged
merged 13 commits into from
Jul 2, 2020

Conversation

BryanPan342
Copy link
Contributor

@BryanPan342 BryanPan342 commented Jun 29, 2020

[ISSUE]
ALB configured with ipAddressType: dualstack and internetFacing: true missing ingress rule for IPv6.

[APPROACH]
Add a property in IApplicationLoadBalancer to obtain ipAddressType in listener constructor.
Add a check in ApplicationListener constructor to check for ipAddressType of dualstack

[NOTE]
Implemented dualstack check only in the constructor because any additional ingress rule should be specified by the user upon further use.

Fixes #7043


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BryanPan342 BryanPan342 requested a review from rix0rrr June 29, 2020 21:07
@BryanPan342 BryanPan342 added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Jun 29, 2020
@BryanPan342
Copy link
Contributor Author

BryanPan342 commented Jun 29, 2020

[ACTIONABLES]

  • Update documentation for IApplicationLoadBalancer

Marked this as done because the interface isn't currently specified in the elbv2 README and adding it doesn't seem to provide substantial benefit for customers (don't want to add to size of README)

  • Add integration tests for 'dualstack' ALB

@BryanPan342
Copy link
Contributor Author

I found creating a IPv6 subnet to be a pain point and it seems some customers agree (#894). Since there is a workaround, I don't think it needs immediate attention but wanted to just point it out to ensure that it doesn't get forgotten. I would also be willing to work on it if I have free time!

@mergify mergify bot dismissed shivlaks’s stale review July 1, 2020 16:34

Pull request has been modified.

@BryanPan342 BryanPan342 requested a review from shivlaks July 1, 2020 16:52
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c1d6de8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 66f9634 into aws:master Jul 2, 2020
@BryanPan342 BryanPan342 deleted the alb branch September 8, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Security Group for Dualstack ALB Doesn't Allow IPv6 Connections
4 participants