Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): fix integ test #8323

Merged
merged 3 commits into from Jun 2, 2020
Merged

chore(cli): fix integ test #8323

merged 3 commits into from Jun 2, 2020

Conversation

shivlaks
Copy link
Contributor

@shivlaks shivlaks commented Jun 2, 2020

Attempt #2
our diff command represents the URLSuffix (typically amazonaws.com)
by using the CloudFormation pseudo-parameter.

modifies the principal in the test to expect it instead. ran tests locally.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

our diff command represents the URLSuffix (typically amazonaws.com)
by using the CloudFormation pseudo-parameter.

modifies the principal in the test to expect it instead
@shivlaks shivlaks added the package/tools Related to AWS CDK Tools or CLI label Jun 2, 2020
@shivlaks shivlaks requested a review from NetaNir June 2, 2020 17:00
@shivlaks shivlaks self-assigned this Jun 2, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 2, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3f1d162
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c31d9c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 42bfda6 into master Jun 2, 2020
@mergify mergify bot deleted the shivlaks/fix-cli-integ branch June 2, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants