fix(spec2cdk): get tag gives null result in Java CDK #29870
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
GavinZZ
changed the title
GavinZZ
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| initializer: (props: Expression) => | ||
| new CDK_CORE.TagManager( | ||
| this.tagManagerVariant(variant), | ||
| expr.lit(this.resource.cloudFormationType), | ||
| expr.UNDEFINED, | ||
| $E(props)[originalName], | ||
| expr.object({ tagPropertyName: expr.lit(originalName) }), | ||
| ), | ||
| cfnValueToRender: { | ||
| [originalName]: $this.tags.renderTags($this[rawTagsPropName]), | ||
| [originalName]: $this.tags.renderTags(), |
There was a problem hiding this comment.
Reverting the changes I made in this PR #28989
There was a problem hiding this comment.
How about the HAS_25610 code? Do we not need to revert that?
[originalName]: $this.tags.renderTags(...(HAS_25610 ? [$this[rawTagsPropName]] : [])),
There was a problem hiding this comment.
No HAS_25610 is always set to false before. So for legacy tagging, this PR changes it back to the original state. For modern tagging style, we want to keep it as is.
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
paulhcsun
changed the title
paulhcsun
changed the title
github-actions
bot
added
effort/small
|
@Mergifyio update |
☑️ Nothing to do
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Issue # (if applicable)
Closes #29869
Reason for this change
Without it, it breaks java users who rely on tagging name to generate resource id.
Description of changes
Provide a default value using the initial
tagValueusers provide.Description of how you validated changes
Existing tests all pass. Essentially changing it back to the original state.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license