Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): specify PreferredMaintenanceWindow in reader or writer props #29686

Merged
merged 11 commits into from
Apr 5, 2024
Merged

feat(rds): specify PreferredMaintenanceWindow in reader or writer props #29686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e177858
Add code and tests
Konosh93 Apr 2, 2024
fac2158
Fix style
Konosh93 Apr 2, 2024
9ef2f6e
Fix docs and test
Konosh93 Apr 3, 2024
ddfa8f4
Add fix
Konosh93 Apr 3, 2024
1210157
Merge branch 'aws:main' into feat/maintenance-window-new-api
Konosh93 Apr 3, 2024
4f1668b
Fix readme
Konosh93 Apr 3, 2024
2fe7f3a
Add fix
Konosh93 Apr 3, 2024
24ba229
Fix docs
Konosh93 Apr 3, 2024
ee9786b
Add fix
Konosh93 Apr 3, 2024
b86a340
Merge branch 'main' into feat/maintenance-window-new-api
Konosh93 Apr 3, 2024
cb4a440
Merge branch 'main' into feat/maintenance-window-new-api
mergify[bot] Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...st/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ-with-feature-flag.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .../aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ-with-feature-flag.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down Expand Up @@ -569,6 +570,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down Expand Up @@ -602,6 +604,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down
6 changes: 3 additions & 3 deletions ...framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions ...amework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand All @@ -547,7 +548,7 @@
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"DatabaseInstanceParameterGroup6968C5BF": {
"DatabaseInstance2WrapperInstanceParameterGroup61FBD67B": {
"Type": "AWS::RDS::DBParameterGroup",
"Properties": {
"Description": "Parameter group for aurora-mysql8.0",
Expand All @@ -563,12 +564,13 @@
},
"DBInstanceClass": "db.t3.medium",
"DBParameterGroupName": {
"Ref": "DatabaseInstanceParameterGroup6968C5BF"
"Ref": "DatabaseInstance2WrapperInstanceParameterGroup61FBD67B"
},
"DBSubnetGroupName": {
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down
2 changes: 1 addition & 1 deletion ...ages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...s/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 15 additions & 5 deletions ...aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.