Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new aws partitions to CrossAccountZoneDelegationRecord construct #29575

Closed
wants to merge 2 commits into from

Conversation

aaythapa
Copy link
Contributor

@aaythapa aaythapa commented Mar 21, 2024

Issue # (if applicable)

Internal ticket

Reason for this change

Customers can't use this construct in new partitions as they're not included in the static list that we maintain. There is another PR to give customers another route for future regions but this should be the fix for now.

Description of changes

Add new partition to static list

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 21, 2024 21:59
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 21, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 832c209
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aaythapa
Copy link
Contributor Author

Duplicate PR to #29537

@aaythapa aaythapa closed this Mar 22, 2024
@aaythapa aaythapa deleted the add-new-partitions branch March 22, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants