Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): credentialSpecs in ContainerDefinitionOptions #29085

Merged
merged 14 commits into from
Feb 16, 2024
Merged

feat(ecs): credentialSpecs in ContainerDefinitionOptions #29085

merged 14 commits into from
Feb 16, 2024

Commits on Feb 13, 2024

  1. Adding L2 construct support for setting the AWS::ECS::TaskDefinition … 

    …ContainerDefinitions.CredentialSpecs property
    @cresvi
    cresvi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    ae681a2 View commit details
    Browse the repository at this point in the history

  2. Added integration test for previous commit

    @cresvi
    cresvi committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6a21674 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Added Readme update

    @cresvi
    cresvi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2b49d5c View commit details
    Browse the repository at this point in the history

  2. Added integration test snapshot

    @cresvi
    cresvi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    e0b3e1e View commit details
    Browse the repository at this point in the history

  3. Update packages/aws-cdk-lib/aws-ecs/README.md 

    Missing semicolon in doc

Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
    @cresvi @kaizencc
    cresvi and kaizencc committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7edc755 View commit details
    Browse the repository at this point in the history

  4. Fixes error in name for integration tests

    @cresvi
    cresvi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cde5c1a View commit details
    Browse the repository at this point in the history

  5. Fixe example on Readme

    @cresvi
    cresvi committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    077781c View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Updated credential spec implementation. Untested

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b6a4cc0 View commit details
    Browse the repository at this point in the history

  2. UPdated credential spec code and added additional unit tests

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    55dd28a View commit details
    Browse the repository at this point in the history

  3. Updated integration test with new credSpec API

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    b1c92a6 View commit details
    Browse the repository at this point in the history

  4. Removed versioning from s3 objects

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8f565ba View commit details
    Browse the repository at this point in the history

  5. Attended comments; Updated integ test

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    73ea435 View commit details
    Browse the repository at this point in the history

  6. Added logic to validate only 1 credspec is provided

    @cresvi
    cresvi committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    67a97ae View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into cresvi/ecs-credentialSpecs

    @mergify
    mergify[bot] committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    8698eb2 View commit details
    Browse the repository at this point in the history