Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add doc db cluster as supported snapshot #28868

Closed
wants to merge 1 commit into from

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jan 25, 2024

According to documentation, doc db cluster should support snapshot as deletion policy.

Add it. Not breaking change because users won't be able to use snapshot at all before the change (fail at synthesize step).

Closes #28861


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 labels Jan 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 25, 2024 21:05
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 25, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a626671
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@GavinZZ GavinZZ marked this pull request as ready for review January 25, 2024 21:46
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Jan 26, 2024

Closing this PR as it's included #28798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-docdb): unsupported snapshot policy although documentation says it should be
2 participants