-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-resources): custom resource response may silently get dropped #28826
Merged
Commits on Jan 23, 2024
-
fix(custom-resources): custom resource response may silently get dropped
It looks like in our custom resource response senders, we are not checking the HTTP result code of making the `PUT` request to the presigned URL. This allows for the possibility that we don't detect that we got a 500, exit successfully, and drop the response on the floor. Also log the URL we're writing to so that it becomes easier to debug missing object PUTs. Yes, I am aware that there is awkward duplication going on here. I'm optimizing for quick delivery here.
Configuration menu - View commit details
-
Copy full SHA for 5ff0793 - Browse repository at this point
Copy the full SHA 5ff0793View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4318606 - Browse repository at this point
Copy the full SHA 4318606View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a88c0f2 - Browse repository at this point
Copy the full SHA a88c0f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f366d7 - Browse repository at this point
Copy the full SHA 4f366d7View commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4082528 - Browse repository at this point
Copy the full SHA 4082528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c464dc - Browse repository at this point
Copy the full SHA 5c464dcView commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 37a260f - Browse repository at this point
Copy the full SHA 37a260fView commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0655413 - Browse repository at this point
Copy the full SHA 0655413View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6d314 - Browse repository at this point
Copy the full SHA 7e6d314View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1333ad6 - Browse repository at this point
Copy the full SHA 1333ad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c95adbc - Browse repository at this point
Copy the full SHA c95adbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3461bd - Browse repository at this point
Copy the full SHA f3461bdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.