Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): custom resource response may silently get dropped #28826

Merged
merged 12 commits into from
Feb 26, 2024

Commits on Jan 23, 2024

  1. fix(custom-resources): custom resource response may silently get dropped

    It looks like in our custom resource response senders, we are not
    checking the HTTP result code of making the `PUT` request to the
    presigned URL.
    
    This allows for the possibility that we don't detect that we got a
    500, exit successfully, and drop the response on the floor.
    
    Also log the URL we're writing to so that it becomes easier to debug
    missing object PUTs.
    
    Yes, I am aware that there is awkward duplication going on here. I'm
    optimizing for quick delivery here.
    rix0rrr committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5ff0793 View commit details
    Browse the repository at this point in the history
  2. Snapshots

    rix0rrr committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4318606 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. More snapshots

    rix0rrr committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a88c0f2 View commit details
    Browse the repository at this point in the history
  2. Add update script

    rix0rrr committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4f366d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    4082528 View commit details
    Browse the repository at this point in the history
  2. Snapshots

    rix0rrr committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5c464dc View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    37a260f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    0655413 View commit details
    Browse the repository at this point in the history
  2. Update snapshots

    rix0rrr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7e6d314 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1333ad6 View commit details
    Browse the repository at this point in the history
  4. Update single hash

    rix0rrr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    c95adbc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f3461bd View commit details
    Browse the repository at this point in the history