Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): healthCheck property for ApplicationLoadBalancedFargateService #28797

Merged
merged 7 commits into from
Feb 6, 2024
Merged

feat(ecs-patterns): healthCheck property for ApplicationLoadBalancedFargateService #28797

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ada4aa3
feat(aws-ecs-patterns): add healthCheck property to ApplicationLoadBa…
Nikola-Milovic Jan 20, 2024
9e84611
update readme
Nikola-Milovic Jan 23, 2024
5f388b2
added unit test
Nikola-Milovic Jan 24, 2024
20079d2
added integration test
Nikola-Milovic Jan 24, 2024
f41eb07
change task image and the health check command
Nikola-Milovic Jan 25, 2024
7c3b301
add link to healthcheck docs in readme
Nikola-Milovic Feb 6, 2024
8a00212
Merge branch 'main' into feature/healthcheck-property-app-lb-fargate-svc
aaythapa Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...ges/aws-cdk-lib/aws-ecs-patterns/lib/fargate/application-load-balanced-fargate-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Construct } from 'constructs';
import { ISecurityGroup, SubnetSelection } from '../../../aws-ec2';
import { FargateService, FargateTaskDefinition } from '../../../aws-ecs';
import { FargateService, FargateTaskDefinition, HealthCheck } from '../../../aws-ecs';
import { FeatureFlags, Token } from '../../../core';
import * as cxapi from '../../../cx-api';
import { ApplicationLoadBalancedServiceBase, ApplicationLoadBalancedServiceBaseProps } from '../base/application-load-balanced-service-base';
Expand Down Expand Up @@ -29,6 +29,13 @@ export interface ApplicationLoadBalancedFargateServiceProps extends ApplicationL
* @default - A new security group is created.
*/
readonly securityGroups?: ISecurityGroup[];

/**
* The health check command and associated configuration parameters for the container.
*
* @default - Health check configuration from container.
*/
readonly healthCheck?: HealthCheck;
}

/**
Expand Down Expand Up @@ -82,6 +89,7 @@ export class ApplicationLoadBalancedFargateService extends ApplicationLoadBalanc
const containerName = taskImageOptions.containerName ?? 'web';
const container = this.taskDefinition.addContainer(containerName, {
image: taskImageOptions.image,
healthCheck: props.healthCheck,
logging: logDriver,
environment: taskImageOptions.environment,
secrets: taskImageOptions.secrets,
Expand Down