Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to get CFN types resolved in exports #28768

Merged
merged 21 commits into from
Mar 16, 2024

Conversation

frankpengau
Copy link
Contributor

@frankpengau frankpengau commented Jan 19, 2024

Issue still persists after #28680.

node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations.

1 import type { CloudFormation } from 'aws-sdk';
                                      ~~~~~~~~~


Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1

Types are still required as a direct dependency in package.json.

Closes #28679


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 19, 2024 00:20
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@frankpengau
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Jan 19, 2024
@frankpengau
Copy link
Contributor Author

frankpengau commented Jan 26, 2024

@pahud Can I trouble you to get someone to review this? The previous PR linked in the description did not resolve the issue.

@frankpengau
Copy link
Contributor Author

@kylelaker @comcalvi Any other suggestions? Otherwise, based off other usage in the repo for import type, going to try and push ahead for this change.

k-asm added a commit to k-asm/cdk_plan_action that referenced this pull request Feb 22, 2024
2.119.0 doesn't work due to the following issue

aws/aws-cdk#28768
@paulhcsun paulhcsun added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Feb 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 23, 2024 00:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@paulhcsun paulhcsun changed the title fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to get cfn types resolved in exports fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to get CFN types resolved in exports Feb 23, 2024
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frankpengau, looks like the codebuild is failing and is requiring you to just run yarn install to install a missing dependency.

@frankpengau
Copy link
Contributor Author

@paulhcsun Thanks for looking at this PR!

Currently on extended AL for another week and don't have my laptop with me.

If urgent, happy for you to take over.

If not, happy to address things once I'm back in a week's time. :)

@mergify mergify bot dismissed paulhcsun’s stale review February 29, 2024 18:14

Pull request has been modified.

@paulhcsun
Copy link
Contributor

Hi @frankpengau, I've pushed the yarn.lock changes. Could you explain why the aws-sdk version was downgraded to "2.1548.0"?

@frankpengau
Copy link
Contributor Author

Sorry @paulhcsun , just got around to this, updated yarn lock and also version to latest on main. Please re-review at your earliest convenience! Many Thanks

@frankpengau
Copy link
Contributor Author

frankpengau commented Mar 14, 2024

I think these pipeline errors are coming from upstream changes? Probably related to this merged PR: #29471 with similar build log error? Or possibly before or external factors?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2ca5f26
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 28c4be3 into aws:main Mar 16, 2024
10 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 16, 2024
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
…get CFN types resolved in exports (aws#28768)

Issue still persists after aws#28680. 
```
node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations.

1 import type { CloudFormation } from 'aws-sdk';
                                      ~~~~~~~~~


Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1
```

Types are still required as a direct dependency in package.json.

Closes aws#28679 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudformation-diff: Hidden dependency on aws-sdk
3 participants