Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudformation-diff): Fix aws-sdk dependency issue #28680

Merged
merged 11 commits into from
Jan 16, 2024
Merged

fix(cloudformation-diff): Fix aws-sdk dependency issue #28680

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
48ae7a9
Moved aws-sdk from devDependencies to dependencies
frankpengau Jan 12, 2024
0e30edc
Update package.json
frankpengau Jan 12, 2024
eba9c7f
change to import type for cfn from aws-sdk
frankpengau Jan 13, 2024
eace329
Merge branch 'main' into patch-1
frankpengau Jan 13, 2024
311960f
Update package.json
frankpengau Jan 13, 2024
79bd6f5
Merge branch 'main' into patch-1
frankpengau Jan 14, 2024
441163f
Merge branch 'main' into patch-1
frankpengau Jan 15, 2024
0e254bd
Merge branch 'main' into patch-1
frankpengau Jan 15, 2024
7fe7f9d
Merge branch 'main' into patch-1
frankpengau Jan 16, 2024
1694524
Merge branch 'main' into patch-1
frankpengau Jan 16, 2024
21ad562
Merge branch 'main' into patch-1
mergify[bot] Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// The SDK is only used to reference `DescribeChangeSetOutput`, so the SDK is added as a devDependency.
// The SDK should not make network calls here
// eslint-disable-next-line import/no-extraneous-dependencies
import { CloudFormation } from 'aws-sdk';
import type { CloudFormation } from 'aws-sdk';
import * as impl from './diff';
import * as types from './diff/types';
import { deepEqual, diffKeyedEntities, unionOf } from './diff/util';
Expand Down