feat(lambda-event-sources): S3EventSource requires Bucket instead of IBucket

[Styerp]

Closes #23940
Closes #4323

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[Styerp]

Exemption Request

I don't think this needs a readme update, since this makes it work how folks expect, but I can modify one if there's a reasonable spot.

Caveats called out in other threads are already covered by other validations and readmes.

[corrjo]

Would love to see this merged and get rid of my forced casting to s3.Bucket 🙃

[TheRealAmazonKendra]

We cannot accept changes without a passing build. It looks like the snapshots have been incorrectly generated to be .ts instead of .js. Please delete them and rerun the tests without the typescript language flag.

[Styerp]

No clue how I generated snapshots as TS instead of JS... Thanks for the call out, Kendra. That part's cleared up.

I think I need additional guidance on the "breaking" API change that's now failing the build:

API elements with incompatible changes:
err - PROP aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket: type aws-cdk-lib.aws_s3.IBucket (formerly aws-cdk-lib.aws_s3.Bucket): aws-cdk-lib.aws_s3.IBucket does not extend aws-cdk-lib.aws_s3.Bucket [changed-type:aws-cdk-lib.aws_lambda_event_sources.S3EventSource.bucket]
Some packages seem to have undergone breaking API changes. Please avoid.

This "breaking" change is the point -- it's not breaking, it's easing.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f1e9c94
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[Styerp]

API surface changes says changes would cause builds to fail -- that will not happen here. Underlying objects didn't access Bucket methods on the object passed into this function, either directly or indirectly. All properties and objects being used were already available on the IBucket, which was the driving rationale to ease this input type.

While this is ostensibly an API Surface Change, it is NOT a breaking surface change.

Behavior changes say "even though the user didn't change their code, the CloudFormation template that gets synthesized is now different." The integration tests prove this is not the case -- the CFN generated is identical.

Build will continue to fail because of the "Breaking API Changes". Guidance on how y'all handle this would be great. Clarification Request

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[Styerp]

Wasn't abandoned, was actively worked on. Didn't have input from the maintaining team. Reopening, if I can.