Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-resources): AwsCustomResource copy physicalResourceId from request when omit it in onUpdate #24194

Merged
merged 7 commits into from Mar 8, 2023
Merged

feat(custom-resources): AwsCustomResource copy physicalResourceId from request when omit it in onUpdate #24194

merged 7 commits into from Mar 8, 2023

Commits on Mar 6, 2023

  1. feat(custom-resources): AwsCustomResource passthrough physicalResourceId 

    when omit it in onUpdate

closes aws#23843
    @konokenj
    konokenj committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    aecf8c6 View commit details
    Browse the repository at this point in the history

  2. update readme

    @konokenj
    konokenj committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4ed9fda View commit details
    Browse the repository at this point in the history

  3. add unit tests

    @konokenj
    konokenj committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3f79c30 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
    @konokenj @comcalvi
    konokenj and comcalvi committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    c198aeb View commit details
    Browse the repository at this point in the history

  5. revert style fix

    @konokenj
    konokenj committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1d78eb6 View commit details
    Browse the repository at this point in the history

  6. use single quotes in error message

    @konokenj
    konokenj committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1880369 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge branch 'main' into konokenj/passthrough-physical-resource-id

    @mergify
    mergify[bot] committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    7627dad View commit details
    Browse the repository at this point in the history