Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticloadbalancingv2): enforce security group inbound rules prop #29522

Merged
merged 9 commits into from Mar 22, 2024
Merged

feat(elasticloadbalancingv2): enforce security group inbound rules prop #29522

merged 9 commits into from Mar 22, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 17, 2024

Closes #29516.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the feature-request A feature should be added or improved. label Mar 17, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2024 04:01
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Mar 17, 2024
@msambol msambol changed the title feat(elasticloadbalancingv2): EnforceSecurityGroupInboundRulesOnPriva… feat(elasticloadbalancingv2): EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic for NLB Mar 17, 2024
@msambol msambol changed the title feat(elasticloadbalancingv2): EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic for NLB feat(elasticloadbalancingv2): enforce security group inbound rules prop Mar 17, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2024
lpizzinidev
lpizzinidev suggested changes Mar 17, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Left a suggestion for changing the variable type

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-load-balancer.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 17, 2024
@msambol
Copy link
Contributor Author

msambol commented Mar 17, 2024 •
edited

@lpizzinidev Let me know what you think of this. I was going down the getter/setter route but it got convoluted with the transformation from boolean to string. I think this might be cleaner?

@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
@tim-finnigan tim-finnigan mentioned this pull request Mar 18, 2024
Closed
2 tasks
lpizzinidev
lpizzinidev suggested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 👍
Left some suggestions, feel free to improve it further

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-load-balancer.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-elasticloadbalancingv2/README.md Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-load-balancer.ts Outdated Show resolved Hide resolved
lpizzinidev
lpizzinidev approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 19, 2024
@godwingrs22 godwingrs22 self-requested a review March 21, 2024 23:32
godwingrs22
godwingrs22 previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks msambol for contributing and lpizzinidev for the review

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed godwingrs22’s stale review March 22, 2024 02:24

Pull request has been modified.

@msambol
Copy link
Contributor Author

msambol commented Mar 22, 2024

@godwingrs22 Do you mind re-reviewing this? I had to rebase on main.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 22, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7a2ff19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8df2823 into aws:main Mar 22, 2024
12 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this pull request Mar 23, 2024
@msambol @jun1-t
feat(elasticloadbalancingv2): enforce security group inbound rules pr…
e331d01 
…op (aws#29522)

Closes aws#29516.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
@msambol @ahammond
feat(elasticloadbalancingv2): enforce security group inbound rules pr…
5616672 
…op (aws#29522)

Closes aws#29516.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godwingrs22 godwingrs22 godwingrs22 approved these changes

@lpizzinidev lpizzinidev lpizzinidev approved these changes

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-elasticloadbalancingv2): NetworkLoadbalancer support EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic
4 participants
@msambol @aws-cdk-automation @godwingrs22 @lpizzinidev