Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-elasticloadbalancingv2): NetworkLoadbalancer support EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic #29516

Closed
2 tasks
paihu opened this issue Mar 16, 2024 · 2 comments · Fixed by #29522
Closed
2 tasks

(aws-elasticloadbalancingv2): NetworkLoadbalancer support EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic #29516

paihu opened this issue Mar 16, 2024 · 2 comments · Fixed by #29522
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@paihu
Copy link

paihu commented Mar 16, 2024

Describe the feature

L1Construct support EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic #28878.
But L2Construct not support this.

Use Case

Use NetorkLoadbalancer with VPC Endpoint Service,
This parameter allow ignore security group when traffic from VPC Endpoint.

Proposed Solution

NetworkLoadbalancer pass through EnforceSecurityGroupInboundRulesOnPrivateLinkTraffic

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.133.0

Environment details (OS name and version, etc.)

windows 11
@paihu paihu added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 16, 2024
@msambol msambol mentioned this issue Mar 17, 2024
Merged
@github-actions github-actions bot mentioned this issue Mar 18, 2024
Closed
@tim-finnigan tim-finnigan self-assigned this Mar 18, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2024
@tim-finnigan
Copy link

Thanks for the feature request! It looks like a PR (#29522) was already created for this.

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 18, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 18, 2024
@mergify mergify bot closed this as completed in #29522 Mar 22, 2024
mergify bot pushed a commit that referenced this issue Mar 22, 2024
@msambol
feat(elasticloadbalancingv2): enforce security group inbound rules pr…
8df2823 
…op (#29522)

Closes #29516.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this issue Mar 23, 2024
@msambol @jun1-t
feat(elasticloadbalancingv2): enforce security group inbound rules pr…
e331d01 
…op (aws#29522)

Closes aws#29516.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahammond pushed a commit to ahammond/aws-cdk that referenced this issue Mar 26, 2024
@msambol @ahammond
feat(elasticloadbalancingv2): enforce security group inbound rules pr…
5616672 
…op (aws#29522)

Closes aws#29516.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticloadbalancingv2): enforce security group inbound rules prop msambol/aws-cdk
2 participants
@paihu @tim-finnigan