(aws-docdb): unsupported snapshot policy although documentation says it should be

[kornicameister]

Describe the bug

#28773 addressed the fact that it is impossible to spin up L2 DocumentDbCluster with retention policy said to Snaphost.
Although that is correct for security group inside (there's an escape hatch in DocumentDbCluster that sets cluster's retention policy onto the group) it turned out that cdk synth against DocumentDbCluster with a policy == Snaphost and seperately created security group also fails with an error that this time snaphost policy is not possible for DocumentDbCluster even though documentation says so

Expected Behavior

It is possible to configure DocumentDBCluster with Snapshot removal policy.

Current Behavior

It is not possible to configure said cluster with Snapshot removal policy.

Reproduction Steps

#!/usr/bin/env node

import 'source-map-support/register';

import * as cdk from 'aws-cdk-lib';
import * as docdb from 'aws-cdk-lib/aws-docdb';
import * as ec2 from 'aws-cdk-lib/aws-ec2';

const app = new cdk.App();
const stack = new cdk.Stack(app, 'Stack');

const vpc = new ec2.Vpc(stack, 'VPC');
const securityGroup = new ec2.SecurityGroup(stack, 'SG', {
  vpc,
});
new docdb.DatabaseCluster(stack, 'Cluster', {
  vpc,
  removalPolicy: cdk.RemovalPolicy.SNAPSHOT,
  securityGroup,
  instanceType: ec2.InstanceType.of(
    ec2.InstanceClass.A1,
    ec2.InstanceSize.SMALL,
  ),
  masterUser: {
    username: 'admin',
    password: cdk.SecretValue.unsafePlainText('password'),
  },
});

app.synth();

Possible Solution

@lpizzinidev mentioned that there might some sort of a list that needs to be updated to allow sscce to synthetize but I have no idea what that is and where that is.

Additional Information/Context

No response

CDK CLI Version

2.121.1

Framework Version

No response

Node.js Version

20.8

OS

MacOS sierra

Language

TypeScript

Language Version

5.3

Other information

No response

[GavinZZ]

I believe the issue is that the list here is missing AWS::DocDB::DBCluster. Going to draft a PR to add it.

[kornicameister]

Wonderful @GavinZZ , thx a lot.
I kinda though this list is something that happens in CloudFormation native code.
Good that was not the case.

[lpizzinidev]

@GavinZZ
I already opened a PR for the fix.

[GavinZZ]

@lpizzinidev Noted, I will close my PR. Please in the future assign your self to the issue or linked the issue in your PR to avoid wasted effort. Thank you!

[lpizzinidev]

@GavinZZ
I did as you can see in my PR description.
This issue is a duplicate that was opened after my PR.
Thanks for pointing out 👍

[kornicameister]

It is a bit of my fault. I did not notice @lpizzinidev has included the change.

[lpizzinidev]

@kornicameister
No worries. It's better to have two open issues for a bug than none 😉

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.