fix(cloudformation-diff): move aws-sdk to dependency for cfn-diff to get CFN types resolved in exports #28768
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Exemption Request |
aws-cdk-automation
added
pr-linter/exemption-requested
|
@pahud Can I trouble you to get someone to review this? The previous PR linked in the description did not resolve the issue. |
|
@kylelaker @comcalvi Any other suggestions? Otherwise, based off other usage in the repo for import type, going to try and push ahead for this change. |
2.119.0 doesn't work due to the following issue aws/aws-cdk#28768
paulhcsun
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
paulhcsun
changed the title
There was a problem hiding this comment.
Hi @frankpengau, looks like the codebuild is failing and is requiring you to just run yarn install to install a missing dependency.
|
@paulhcsun Thanks for looking at this PR! Currently on extended AL for another week and don't have my laptop with me. If urgent, happy for you to take over. If not, happy to address things once I'm back in a week's time. :) |
mergify
bot
dismissed
paulhcsun’s stale review
Pull request has been modified.
|
Hi @frankpengau, I've pushed the yarn.lock changes. Could you explain why the |
|
Sorry @paulhcsun , just got around to this, updated yarn lock and also version to latest on main. Please re-review at your earliest convenience! Many Thanks |
|
I think these pipeline errors are coming from upstream changes? Probably related to this merged PR: #29471 with similar build log error? Or possibly before or external factors? |
This reverts commit 02413c2.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
…get CFN types resolved in exports (aws#28768) Issue still persists after aws#28680. ``` node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations. 1 import type { CloudFormation } from 'aws-sdk'; ~~~~~~~~~ Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1 ``` Types are still required as a direct dependency in package.json. Closes aws#28679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Issue still persists after #28680.
Types are still required as a direct dependency in package.json.
Closes #28679
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license