Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipelines): Ubuntu 5 images will be slow, move to Ubuntu 6 #24544

Merged
merged 5 commits into from Mar 9, 2023
Merged

fix(pipelines): Ubuntu 5 images will be slow, move to Ubuntu 6 #24544

merged 5 commits into from Mar 9, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 9, 2023 •
edited

CodeBuild has moved the STANDARD_5 images to the slow path, meaning they will not be cached on the host anymore. Every customer using CDK Pipelines has gotten an email about this.

Move the CDK Pipelines default image to STANDARD_6.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
fix(pipelines): Ubuntu 5 images will be slow, move to Ubuntu 6
4336ad5 
CodeBuild has moved the `STANDARD_5` images to the slow path, meaning
they will not be cached on the host anymore. Every customr using CDK
Pipelines has gotten an email about this.

Move the CDK Pipelines standard image to `STANDARD_6`.
@rix0rrr rix0rrr requested a review from a team March 9, 2023 09:17
@rix0rrr rix0rrr self-assigned this Mar 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 9, 2023 09:17
@github-actions github-actions bot added the p2 label Mar 9, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 9, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Mar 9, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 9, 2023 09:38

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

Naumel
Naumel approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Naumel Naumel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 matches of STANDARD_5_0
5 matches of STANDARD_6_0
13 matches of CDKP_DEFAULT_CODEBUILD_IMAGE
All looks good from my side √

Added the do-not-merge label in case you'd like another pair of eyes, since the number of changes files is not trivial.

@Naumel Naumel added the pr/do-not-merge This PR should not be merged at this time. label Mar 9, 2023
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Mar 9, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4d97de8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1f62c43 into main Mar 9, 2023
5 checks passed
@mergify mergify bot deleted the huijbers/codebuild-ubuntu-6 branch March 9, 2023 11:08
This was referenced Mar 9, 2023
Open
Closed
Closed
Closed
@peterwoodworth peterwoodworth mentioned this pull request Mar 15, 2023
Closed
@vumdao vumdao mentioned this pull request Mar 16, 2023
Open
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@rix0rrr @homakk
fix(pipelines): Ubuntu 5 images will be slow, move to Ubuntu 6 (aws#2…
4023120 
…4544)

CodeBuild has moved the `STANDARD_5` images to the slow path, meaning they will not be cached on the host anymore. Every customer using CDK Pipelines has gotten an email about this.

Move the CDK Pipelines default image to `STANDARD_6`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@philberesford-bjss
Copy link

FWIW, AWS-CDK 2.69.0 had breaking changes (incorrectly reported as bug-fix) since the new default of Ubuntu 6 does not support the Python 3.9 runtime.
Recording here for other engineers who come a cropper.

@ericljiang ericljiang mentioned this pull request May 10, 2023
Closed
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@peterwoodworth peterwoodworth mentioned this pull request Aug 18, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naumel Naumel Naumel approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rix0rrr @aws-cdk-automation @philberesford-bjss @Naumel