Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdk-pipelines: Node 16 is approaching end-of-life #26810

Closed
2 tasks done
modosm opened this issue Aug 18, 2023 · 6 comments · Fixed by #26817
Closed
2 tasks done

cdk-pipelines: Node 16 is approaching end-of-life #26810

modosm opened this issue Aug 18, 2023 · 6 comments · Fixed by #26817
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@modosm
Copy link

modosm commented Aug 18, 2023

Describe the feature

Currently cdk pipelines are using the aws/codebuild/standard:6.0 image on CodeBuild. Please update the default image to aws/codebuild/standard:7.0 or to aws/codebuild/amazonlinux2-aarch64-standard:3.0.

Use Case

Node 16 is approaching end-of-life and will no longer be supported in new releases after 2023-09-11
Please upgrade to a supported node version as soon as possible.

Proposed Solution

Update the CDKP_DEFAULT_CODEBUILD_IMAGE to LinuxBuildImage.STANDARD_7_0 or to AMAZON_LINUX_2_5 in packages/aws-cdk-lib/pipelines/lib/private/default-codebuild-image.ts

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.92.0 (build bf62e55)

Environment details (OS name and version, etc.)

CodeBuild

@modosm modosm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2023
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Aug 18, 2023
@peterwoodworth
Copy link
Contributor

Thankfully, Rico made this really easy to change the last time we changed the default image

export const CDKP_DEFAULT_CODEBUILD_IMAGE = LinuxBuildImage.STANDARD_6_0;

@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2023
@modosm
Copy link
Author

modosm commented Aug 22, 2023

Hey @peterwoodworth,

I have tried to update one of my CDK pipelines to LinuxBuildImage.STANDARD_7_0 but looks like CodeBuild is not synthesizes any template with node 18 and so the cdk.out directory is not created.

[Container] 2023/08/22 11:39:55 Running command npx cdk synth --verbose 2>&1

[Container] 2023/08/22 11:39:57 Running command make security_scan
…
find: ‘cdk.out’: No such file or directory

[Container] 2023/08/22 11:40:41 Phase complete: BUILD State: SUCCEEDED
[Container] 2023/08/22 11:40:41 Phase context status code:  Message: 
[Container] 2023/08/22 11:40:41 Entering phase POST_BUILD
[Container] 2023/08/22 11:40:41 Phase complete: POST_BUILD State: SUCCEEDED
[Container] 2023/08/22 11:40:41 Phase context status code:  Message: 
[Container] 2023/08/22 11:40:41 Expanding base directory path: cdk/cdk.out
[Container] 2023/08/22 11:40:41 Assembling file list
[Container] 2023/08/22 11:40:41 Expanding cdk/cdk.out
[Container] 2023/08/22 11:40:41 Skipping invalid file path cdk/cdk.out
[Container] 2023/08/22 11:40:41 Phase complete: UPLOAD_ARTIFACTS State: FAILED
[Container] 2023/08/22 11:40:41 Phase context status code: CLIENT_ERROR Message: no matching base directory path found for cdk/cdk.out

rix0rrr added a commit to lpizzinidev/aws-cdk that referenced this issue Aug 22, 2023
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Aug 22, 2023
@mergify mergify bot closed this as completed in #26817 Aug 22, 2023
mergify bot pushed a commit that referenced this issue Aug 22, 2023
…untu7 (#26817)

Node 16 is approaching end-of-life (2023-09-11).
This changes the default image version to `aws/codebuild/standard:7.0` which uses Node 18.

Closes #26810.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@adriantaut
Copy link
Contributor

getting error with latest STANDARD_7_0 images while synthing in CDK Pipelines



[Container] 2023/08/31 08:47:39 Running command npm run build
--
51 |  
52 | > cdk@0.1.0 build
53 | > tsc
54 |  
55 |  
56 | [Container] 2023/08/31 08:48:02 Running command npx --version
57 | 9.5.1
58 |  
59 | [Container] 2023/08/31 08:48:03 Running command npx cdk synth
60 | /root/.npm/_npx/6c73beee0e79a1b5/node_modules/.bin/cdk: 1: use strict: not found
61 | /root/.npm/_npx/6c73beee0e79a1b5/node_modules/.bin/cdk: 2: Syntax error: word unexpected (expecting ")")


anyone facing the same? 🤔

@ChrisLahaye
Copy link

@modosm same issue here, did you find a solution?

@best-cloud
Copy link

It happens in aws/codebuild/standard:7.0 and The Amazon Linux 2 x86_64 standard image, version 5.0.

Can someone fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants