change to star

aws · Feb 17, 2024 · 9516130 · 9516130
1 parent d02580d
commit 9516130
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 24 deletions.
diff --git a/...nteg/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/SNSTopicPolicyStack.assets.json b/...nteg/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/SNSTopicPolicyStack.assets.json
diff --git a/...eg/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/SNSTopicPolicyStack.template.json b/...eg/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/SNSTopicPolicyStack.template.json
@@ -31,9 +31,7 @@
         }
        },
        "Effect": "Deny",
-       "Principal": {
-        "AWS": "*"
-       },
+       "Principal": "*",
        "Resource": {
         "Ref": "TopicBFC7AF6E"
        },
@@ -80,9 +78,7 @@
         }
        },
        "Effect": "Deny",
-       "Principal": {
-        "AWS": "*"
-       },
+       "Principal": "*",
        "Resource": {
         "Ref": "TopicAddPolicy7DB03706"
        },

diff --git a/...esting/framework-integ/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/manifest.json b/...esting/framework-integ/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/manifest.json
diff --git a/...dk-testing/framework-integ/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/tree.json b/...dk-testing/framework-integ/test/aws-sns/test/integ.sns-topic-policy.js.snapshot/tree.json
diff --git a/packages/aws-cdk-lib/aws-sns/lib/policy.ts b/packages/aws-cdk-lib/aws-sns/lib/policy.ts
@@ -1,7 +1,7 @@
 import { Construct } from 'constructs';
 import { CfnTopicPolicy } from './sns.generated';
 import { ITopic } from './topic-base';
-import { AnyPrincipal, Effect, PolicyDocument, PolicyStatement } from '../../aws-iam';
+import { Effect, PolicyDocument, PolicyStatement, StarPrincipal } from '../../aws-iam';
 import { Resource } from '../../core';
 
 /**
@@ -84,7 +84,7 @@ export class TopicPolicy extends Resource {
       conditions: {
         Bool: { 'aws:SecureTransport': 'false' },
       },
-      principals: [new AnyPrincipal()],
+      principals: [new StarPrincipal()],
     });
   }
 }
diff --git a/packages/aws-cdk-lib/aws-sns/lib/topic-base.ts b/packages/aws-cdk-lib/aws-sns/lib/topic-base.ts
@@ -169,7 +169,7 @@ export abstract class TopicBase extends Resource implements ITopic {
       conditions: {
         Bool: { 'aws:SecureTransport': 'false' },
       },
-      principals: [new iam.AnyPrincipal()],
+      principals: [new iam.StarPrincipal()],
     });
   }
 

diff --git a/packages/aws-cdk-lib/aws-sns/test/sns.test.ts b/packages/aws-cdk-lib/aws-sns/test/sns.test.ts
@@ -224,7 +224,7 @@ describe('Topic', () => {
                 'aws:SecureTransport': 'false',
               },
             },
-            'Principal': { 'AWS': '*' },
+            'Principal': '*',
           },
         ],
       },
@@ -353,7 +353,7 @@ describe('Topic', () => {
                 'aws:SecureTransport': 'false',
               },
             },
-            'Principal': { 'AWS': '*' },
+            'Principal': '*',
           },
         ],
         'Version': '2012-10-17',