chore(pipelines): migrate approve lambda handler (#27828)

This PR moves the approve lambda handler from aws-cdk-lib to our new centralized location for custom resource handlers in the [@aws-cdk](https://github.com/aws-cdk) package. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws · Nov 10, 2023 · 60c890c · 60c890c
1 parent 633dbe2
commit 60c890c
Show file tree

Hide file tree

Showing 13 changed files with 14 additions and 104 deletions.
diff --git a/...test/pipelines/test/integ.pipeline-security.js.snapshot/PipelineSecurityStack.assets.json b/...test/pipelines/test/integ.pipeline-security.js.snapshot/PipelineSecurityStack.assets.json
diff --git a/...st/pipelines/test/integ.pipeline-security.js.snapshot/PipelineSecurityStack.template.json b/...st/pipelines/test/integ.pipeline-security.js.snapshot/PipelineSecurityStack.template.json
@@ -2364,7 +2364,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
      },
-     "S3Key": "8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273.zip"
+     "S3Key": "c2adac8ea3baf51ce56c33ef5da361ea693f7ed128ddbc9777c557e9e7c741a6.zip"
     },
     "Handler": "index.handler",
     "Role": {
@@ -2708,7 +2708,7 @@
      "S3Bucket": {
       "Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
      },
-     "S3Key": "8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273.zip"
+     "S3Key": "c2adac8ea3baf51ce56c33ef5da361ea693f7ed128ddbc9777c557e9e7c741a6.zip"
     },
     "Handler": "index.handler",
     "Role": {

diff --git a/...napshot/asset.8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273/index.d.ts b/...napshot/asset.8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273/index.d.ts
diff --git a/....snapshot/asset.8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273/index.js b/....snapshot/asset.8aa652c34c594d3c7ff1fe10240de14208e0d856f77eb4d56bd01bd9fc1f1273/index.js
diff --git a/....snapshot/asset.c2adac8ea3baf51ce56c33ef5da361ea693f7ed128ddbc9777c557e9e7c741a6/index.js b/....snapshot/asset.c2adac8ea3baf51ce56c33ef5da361ea693f7ed128ddbc9777c557e9e7c741a6/index.js
diff --git a/...ing/framework-integ/test/pipelines/test/integ.pipeline-security.js.snapshot/manifest.json b/...ing/framework-integ/test/pipelines/test/integ.pipeline-security.js.snapshot/manifest.json
diff --git a/...testing/framework-integ/test/pipelines/test/integ.pipeline-security.js.snapshot/tree.json b/...testing/framework-integ/test/pipelines/test/integ.pipeline-security.js.snapshot/tree.json
diff --git a/...08e0d856f77eb4d56bd01bd9fc1f1273/index.ts → ...ers/lib/pipelines/approve-lambda/index.ts b/...08e0d856f77eb4d56bd01bd9fc1f1273/index.ts → ...ers/lib/pipelines/approve-lambda/index.ts
diff --git a/packages/@aws-cdk/custom-resource-handlers/package.json b/packages/@aws-cdk/custom-resource-handlers/package.json
@@ -32,6 +32,7 @@
     "@aws-sdk/client-ssm": "3.421.0",
     "@aws-sdk/client-kinesis": "3.421.0",
     "@aws-sdk/client-kms": "3.421.0",
+    "@aws-sdk/client-codepipeline": "3.421.0",
     "@aws-sdk/client-redshift": "3.421.0",
     "@aws-sdk/client-account": "3.421.0",
     "@smithy/util-stream": "^2.0.12",

diff --git a/...st/private/approve-lambda-handler.test.ts → .../pipelines/approve-lambda-handler.test.ts b/...st/private/approve-lambda-handler.test.ts → .../pipelines/approve-lambda-handler.test.ts
@@ -13,7 +13,7 @@ jest.mock('@aws-sdk/client-codepipeline', () => {
 
 jest.setTimeout(10_000);
 
-import { handler } from '../../lib/private/approve-lambda/index';
+import { handler } from '../../lib/pipelines/approve-lambda/index';
 
 describe('approve-lambda handler', () => {
 

diff --git a/packages/aws-cdk-lib/pipelines/lib/private/application-security-check.ts b/packages/aws-cdk-lib/pipelines/lib/private/application-security-check.ts
@@ -60,7 +60,7 @@ export class ApplicationSecurityCheck extends Construct {
     this.preApproveLambda = new lambda.Function(this, 'CDKPipelinesAutoApprove', {
       handler: 'index.handler',
       runtime: lambda.Runtime.NODEJS_18_X,
-      code: lambda.Code.fromAsset(path.resolve(__dirname, 'approve-lambda')),
+      code: lambda.Code.fromAsset(path.resolve(__dirname, '..', '..', '..', 'custom-resource-handlers', 'dist', 'pipelines', 'approve-lambda')),
       timeout: Duration.minutes(5),
     });
 

diff --git a/packages/aws-cdk-lib/pipelines/lib/private/approve-lambda/.is_custom_resource b/packages/aws-cdk-lib/pipelines/lib/private/approve-lambda/.is_custom_resource
diff --git a/packages/aws-cdk-lib/pipelines/lib/private/approve-lambda/index.ts b/packages/aws-cdk-lib/pipelines/lib/private/approve-lambda/index.ts