IPv6 Security Groups for Pods Support #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
commented
Oct 31, 2023
jdn5126
force-pushed
the
sgpp_v6
branch
4 times, most recently
from
2f07cdb
to
1c86175
Compare
achevuru
reviewed
Nov 7, 2023
achevuru
reviewed
Nov 7, 2023
achevuru
reviewed
Nov 7, 2023
achevuru
reviewed
Nov 7, 2023
jdn5126
force-pushed
the
sgpp_v6
branch
3 times, most recently
from
bd236a8
to
e57c43e
Compare
jdn5126
force-pushed
the
sgpp_v6
branch
3 times, most recently
from
103614d
to
3dd6004
Compare
jdn5126
force-pushed
the
sgpp_v6
branch
3 times, most recently
from
4bcdeef
to
8bccb40
Compare
jayanthvn
reviewed
Nov 28, 2023
achevuru
reviewed
Nov 28, 2023
achevuru
reviewed
Nov 28, 2023
achevuru
reviewed
Nov 30, 2023
|
lgtm |
achevuru
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR adds VPC CNI support for IPv6 Security Groups for Pods. It is dependent on VPC Resource Controller support added in aws/amazon-vpc-resource-controller-k8s#309.
This PR is unfortunately quite large, so to help reviewers, I will call out major areas to focus on:
Initialization
cmd/aws-vpc-cni-init/main.go- default sysctls for IPv6 have been modifiedpkg/ipamd/ipamd.go- configuration of IPv6 Security Groups for Pods needs to be allowedENI Management
pkg/awsutils/awsutils.go- when attaching an IPv6 trunk ENI, the metadata associated with the ENI needs to incorporate IPv6.pkg/ipamd/ipamd.go- when IPv6 Security Groups for Pods is enabled, IPAMD must wait for a trunk ENI to be attachedpkg/networkutils/network.go- support for attaching an IPv6 trunk ENI, which includes getting the IPv6 gateway address and configuring relevant routes and rulesPod Interface Management
cmd/routed-eni-cni-plugin/driver/driver.go- sysctls for branch interfaces and IPv6 veth interfaces are setpkg/ipamd/rpc_handler.go- support for deriving IPv6 branch ENI information from annotationCaching
Testing
test/integration/pod-enihas been made compatible for IPv6Other
I realized that
make unit-testwas not invoking unit tests defined incmd/.... Some of these unit tests were failing, so I made sure all were passing in this PR.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that
test/integration/pod-enipasses. Also manually verified that all existing integration tests pass.Further validation is in progress for upgrade/downgrade, scale, performance, etc.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.