Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Karpenter AddOn: Remove resources in spec.limits.resources.memory #959

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

vumdao
Copy link
Contributor

@vumdao vumdao commented Mar 15, 2024

Issue #, if available:

DeployDev-sel-vc-d1-dev-eks-blueprint: creating CloudFormation changeset...
6:33:57 PM | CREATE_FAILED        | Custom::AWSCDK-EKS-KubernetesResource | selvcd1deveksbluep...efaultpool055A0255
Received response status [FAILED] from custom resource. Message returned: Error: b'Error from server (BadRequest): error when creating "/tmp/manifest.yaml": NodePool in version "v1beta1" cannot be handled as a NodePool: strict
decoding error: unknown field "spec.limits.resources.memory"\n'

Logs: /aws/lambda/DeployDev-sel-vc-d1-dev-eks-bluepr-Handler886CB40B-h954A8KfTkdY

Ref: https://karpenter.sh/docs/concepts/nodepools/#speclimits
eg.

apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  name: default
spec:
  template:
    spec:
      requirements:
        - key: karpenter.sh/capacity-type
          operator: In
          values: ["spot"]
  limits:
    cpu: 1000
    memory: 1000Gi
    nvidia.com/gpu: 2

Description of changes:
Remove resources field

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - this was also missed! Left a minor comment, just for backwards compatibility.

lib/addons/karpenter/index.ts Show resolved Hide resolved
vumdao and others added 2 commits March 15, 2024 23:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@youngjeong46 youngjeong46 self-requested a review March 15, 2024 22:54
Copy link
Collaborator

@youngjeong46 youngjeong46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shapirov103 shapirov103 merged commit 469d0e5 into aws-quickstart:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants