fix: Update isReactNative check to consider Expo as well
#11555
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change fixes a recently introduced regression to the
Platform.isReactNativeutility. Previously this utility would evaluate to totruefor both React Native & Expo, but after a recent refactor it only returns true for React Native.Currently this utility is only used in one place: https://github.com/aws-amplify/amplify-js/blob/main/packages/storage/src/providers/axios-http-handler.ts#L181-L183
Storage's Axios HTTP handler uses a special request transformer on React Native to correctly detect file blobs (vs a normal JS object). When
Platform.isReactNativestopped evaluating to true for Expo, this functionality broke.Issue #, if available
Description of how you validated changes
Tested locally in an Expo app by uploading an image in S3.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.