Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): implement listObjectsV2 #11504

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Jun 15, 2023

Description of changes

Add the listObjectsV2 API of the S3 custom client.

Description of how you validated changes

  • Functional test
  • Manual integration test
  • Add future proof interface to endpoint resolver accepting input parameters
  • Fix: S3 transfer handler provide intellisense of emitter config

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-listObjectsV2 branch 3 times, most recently from 544a8c5 to a1ad088 Compare June 15, 2023 15:55
@AllanZhengYP AllanZhengYP marked this pull request as ready for review June 15, 2023 15:56
@AllanZhengYP AllanZhengYP requested review from a team as code owners June 15, 2023 15:56
@AllanZhengYP AllanZhengYP changed the title V5/custom clients merge list objects v2 feat(s3): implement listObjectsV2 Jun 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #11504 (2c42b1a) into v5/custom-clients (53aa94f) will increase coverage by 0.09%.
The diff coverage is 92.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                  @@
##           v5/custom-clients   #11504      +/-   ##
=====================================================
+ Coverage              83.37%   83.47%   +0.09%     
=====================================================
  Files                    286      295       +9     
  Lines                  20770    20927     +157     
  Branches                4482     4515      +33     
=====================================================
+ Hits                   17318    17468     +150     
- Misses                  3163     3171       +8     
+ Partials                 289      288       -1     
Impacted Files Coverage Δ
...ges/storage/src/AwsClients/S3/runtime/constants.ts 100.00% <ø> (ø)
...c/AwsClients/S3/runtime/contentSha256middleware.ts 90.00% <ø> (ø)
...storage/src/AwsClients/S3/runtime/index.browser.ts 100.00% <ø> (ø)
...c/AwsClients/S3/runtime/s3TransferHandler/fetch.ts 100.00% <ø> (ø)
...src/AwsClients/S3/runtime/s3TransferHandler/xhr.ts 100.00% <ø> (ø)
...storage/src/AwsClients/S3/runtime/xmlParser/dom.ts 93.87% <ø> (ø)
...rage/src/AwsClients/S3/runtime/xmlParser/pureJs.ts 95.83% <ø> (ø)
...es/storage/src/AwsClients/S3/utils/parsePayload.ts 75.00% <75.00%> (ø)
...es/storage/__tests__/AwsClients/testUtils/mocks.ts 95.74% <83.33%> (-4.26%) ⬇️
packages/storage/src/AwsClients/S3/base.ts 91.66% <91.66%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-listObjectsV2 branch from d77b8e1 to be4a542 Compare June 16, 2023 19:58
@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-listObjectsV2 branch from 0fc5bfd to 7e73046 Compare June 16, 2023 21:20
Copy link
Member

@HuiSF HuiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check: the build failure should not be related to the changes in the PR correct?

AllanZhengYP and others added 8 commits June 16, 2023 14:30

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle
…to the endpoint resolver

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle

Verified

This commit was signed with the committer’s verified signature.
alexeagle Alex Eagle

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Hui Zhao <10602282+HuiSF@users.noreply.github.com>
@AllanZhengYP AllanZhengYP force-pushed the v5/custom-clients-merge-listObjectsV2 branch from 7e73046 to 7bd89c9 Compare June 16, 2023 21:30
@AllanZhengYP AllanZhengYP merged commit 0c43bb3 into aws-amplify:v5/custom-clients Jun 16, 2023
kvramyasri7 pushed a commit to kvramyasri7/amplify-js that referenced this pull request Jul 7, 2023
Co-authored-by: Hui Zhao <10602282+HuiSF@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants