Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Storage action enum update #11467

Conversation

stocaaro
Copy link
Member

@stocaaro stocaaro commented Jun 7, 2023

Description of changes

Change the Storage enum to align with the current storage API and update related code/tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@stocaaro stocaaro requested review from a team as code owners June 7, 2023 13:30
@codecov-commenter
Copy link

Codecov Report

Merging #11467 (82a96c9) into feat/user-agent-enhancements/main (4315ba0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                        Coverage Diff                         @@
##           feat/user-agent-enhancements/main   #11467   +/-   ##
==================================================================
  Coverage                              83.37%   83.38%           
==================================================================
  Files                                    294      294           
  Lines                                  20804    20800    -4     
  Branches                                4480     4478    -2     
==================================================================
- Hits                                   17346    17344    -2     
+ Misses                                  3171     3169    -2     
  Partials                                 287      287           
Impacted Files Coverage Δ
packages/core/src/Platform/types.ts 100.00% <100.00%> (ø)
packages/storage/src/providers/AWSS3Provider.ts 91.89% <100.00%> (-0.08%) ⬇️
...torage/src/providers/AWSS3ProviderManagedUpload.ts 96.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stocaaro stocaaro merged commit 460ce37 into aws-amplify:feat/user-agent-enhancements/main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants