Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom user agent enhancements for Predictions #11437

Conversation

stocaaro
Copy link
Member

Description of changes

Add Predictions category with specific actions for the custom user agent in all predictions call except "convert" for voice to text (transcription), which uses websocket streams and doesn't currently support custom user agent.

Description of how you validated changes

Unit tests added to cover user agent detection in sdk client. I'll be going through manual testing for predictions before this is merged to main.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@stocaaro stocaaro requested review from a team as code owners May 31, 2023 18:19
@stocaaro stocaaro requested a review from AllanZhengYP June 1, 2023 15:31
Copy link
Contributor

@erinleigh90 erinleigh90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stocaaro stocaaro merged commit 424e9d4 into aws-amplify:feat/user-agent-enhancements/main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants