Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up @aws-sdk packages to 3.175.0 #10362

Closed
wants to merge 6 commits into from

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Sep 22, 2022

Description of changes

Follow up to #7822, update @aws-sdk packages after over 1.5 years. Targeting the package set in the 3.175.0 release of @aws-sdk

Pending:

  • Integration test
  • Bundle size report

Resolves: #9639

Issue #, if available

Description of how you validated changes

TBD

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP
Copy link
Contributor Author

As per sample app bundle size audition, this upgrade will cause significant bundle size increase(18KB) in at lease storage catagory:

baseline:

Route (pages)                              Size     First Load JS
┌ ○ / (1125 ms)                            267 B          79.5 kB
├   /_app                                  0 B            79.2 kB
├ ○ /404                                   182 B          79.4 kB
├ ○ /auth (1143 ms)                        34.7 kB         163 kB
├ ○ /predictions (1163 ms)                 1.61 kB        80.8 kB
└ ○ /storage (1133 ms)                     54.3 kB         183 kB
+ First Load JS shared by all              79.2 kB
  ├ chunks/framework-7751730b10fa0f74.js   45.5 kB
  ├ chunks/main-e7a7892cb0edc024.js        31 kB
  ├ chunks/pages/_app-adf3896278c18d18.js  1.96 kB
  └ chunks/webpack-59c5c889f52620d6.js     819 B

after:

Route (pages)                              Size     First Load JS
┌ ○ / (886 ms)                             267 B          79.5 kB
├   /_app                                  0 B            79.2 kB
├ ○ /404                                   182 B          79.4 kB
├ ○ /auth (910 ms)                         34.7 kB         168 kB
├ ○ /predictions (894 ms)                  1.61 kB        80.8 kB
└ ○ /storage (926 ms)                      67.7 kB         201 kB
+ First Load JS shared by all              79.2 kB
  ├ chunks/framework-7751730b10fa0f74.js   45.5 kB
  ├ chunks/main-e7a7892cb0edc024.js        31 kB
  ├ chunks/pages/_app-adf3896278c18d18.js  1.96 kB
  └ chunks/webpack-59c5c889f52620d6.js     819 B

@AllanZhengYP
Copy link
Contributor Author

PR to reduce the bundle size increase caused by the aws-sdk: aws/aws-sdk-js-v3#4001. It is current blocked by NaturalIntelligence/fast-xml-parser#501

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Oct 3, 2022

Confirmed the AWS SDK update can resolve the bundling issue with Vite #9639. The result can be confirmed with the sample app in this commit: AllanZhengYP@857745f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use amplify-js in browser environment (breaking vite / snowpack / esbuild)
1 participant