Tweaking types and removing any usage #172
Merged
+70
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is 10.0.9. |
avoidwork
reviewed
Aug 10, 2023
| standard?: 'iec' | 'jedec'; | ||
| output?: 'array' | 'exponent' | 'object' | 'string'; |
There was a problem hiding this comment.
This is very important to not change the behaviour of.
There was a problem hiding this comment.
You are correct. This was also not changed, but rather I overlooked the case that if other options are given and NOT output it also should return string and not force the setting of output. I will wait on the issue opener to create a PR, otherwise I can if wanted.
|
This was reverted for 10.0.10, due to what I'd call a too-strict interface; everything is optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of
anyin typescript type definitions, which would otherwise defeat the purpose of using these types. Function overloading is used to derive the output type from the input options. If no options are given the return type is string, if options are defined theoutput-attribute will derive the output type (array, string, object or exponent).Be warned: these types will work as long as the public API of the project stands, but are still better than
any.