Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-assertions.md because of issue #2624 #3267

Closed
wants to merge 1 commit into from

Conversation

JigmetAvinash
Copy link

Adding text in assertion planning in order to inform about ava assertion not stopping even when they fail linked to issue
#2624 Document that awa assertions don't throw |

I also have 3 of my friends using this tool, I also do. I was thinking why does it not stop and found an issue already. This minor change will help the users very much

Adding text in assertion planning in order to inform about ava assertion not stopping even when they fail
linked to issue 
(document that ava assertions don't throw avajs#2624)
@novemberborn
Copy link
Member

novemberborn commented Dec 4, 2023

Thanks for the PR @ChopCodes!

This paragraph is about assertion planning, so it'd be the wrong place to add this clarification.

However, the behavior has changed in main, see this PR: #3246. Which incidentally also adds the clarification discussed in #2624.

For next time, it can be useful to check when documentation was last changed, through the commit history. That would have made it apparent #2624 can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants