Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only treat native errors as errors #3229

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Only treat native errors as errors #3229

merged 3 commits into from
Jul 31, 2023

Commits on Jul 30, 2023

  1. Track worker errors 

    They're not native due to nodejs/node#48716, but we want to treat them as such anyway.
    @novemberborn
    novemberborn committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    beff6b2 View commit details
    Browse the repository at this point in the history

  2. Only treat native errors as errors 

    * Remove is-error dependency
* Document edge case where `error instanceof Error` can be true, yet AVA does not recognize `error` as an error

See also #2911 for an earlier attempt.
    @novemberborn
    novemberborn committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    0ea5763 View commit details
    Browse the repository at this point in the history

  3. Add tests for native errors and ones that extend the error prototype

    @novemberborn
    novemberborn committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    43b9a34 View commit details
    Browse the repository at this point in the history