Detect process.exit() called from tests #3080
Merged
+130
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A worker cannot observe a peer-failed message sent before it started listening.
gibson042
force-pushed
the
gh-861-process-exit
branch
from
9e1f9fe to
96ff6ef
Compare
|
@gibson042 I should have some time this week to help get this over the line. |
No need for other error details, the error is synthetic anyway.
|
@gibson042 thanks for I've pushed several updates, please let me know what you think. |
|
@novemberborn The updates look good to me. My only further change was to rename the generic |
novemberborn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #861