Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: dynamic block for action.Secrets and iterates via k/v #1115

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

ramya18101
Copy link
Contributor

@ramya18101 ramya18101 commented Jan 13, 2025

🔧 Changes

Update the type of action.Secrets to Set
Update docs for actions and prompt_custom_text

📚 References

Fix made for : #1038

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
ramya18101 Ramya Anusri
and update docs for actions and prompt_custom_text
@ramya18101 ramya18101 linked an issue Jan 13, 2025 that may be closed by this pull request
6 tasks
ramya18101 and others added 2 commits January 13, 2025 10:03

Verified

This commit was signed with the committer’s verified signature.
ramya18101 Ramya Anusri

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (6387564) to head (f8a1160).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/auth0/action/expand.go 41.93% 16 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   89.29%   89.21%   -0.09%     
==========================================
  Files         130      130              
  Lines       18027    18054      +27     
==========================================
+ Hits        16097    16106       +9     
- Misses       1363     1379      +16     
- Partials      567      569       +2     
Files with missing lines Coverage Δ
internal/auth0/action/resource.go 87.30% <100.00%> (ø)
internal/auth0/action/expand.go 81.67% <41.93%> (-12.56%) ⬇️

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ramya18101 ramya18101 marked this pull request as ready for review January 13, 2025 04:55
@ramya18101 ramya18101 requested a review from a team as a code owner January 13, 2025 04:55

Verified

This commit was signed with the committer’s verified signature.
ramya18101 Ramya Anusri

Verified

This commit was signed with the committer’s verified signature.
ramya18101 Ramya Anusri
…/github.com/auth0/terraform-provider-auth0 into fix_dynamic_block_for_action_secrets_handle

Verified

This commit was signed with the committer’s verified signature.
ramya18101 Ramya Anusri
@ramya18101 ramya18101 merged commit bc643f8 into main Jan 15, 2025
5 checks passed
@ramya18101 ramya18101 deleted the fix_dynamic_block_for_action_secrets_handle branch January 15, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic block for secrets iterates via index not via k/v
3 participants