Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alg to SigningKey types #220

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add alg to SigningKey types #220

merged 2 commits into from
Feb 23, 2021

Conversation

okko
Copy link
Contributor

@okko okko commented Feb 15, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fixes #219.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Does not change functionality, fixes type definition only.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@okko okko requested a review from a team as a code owner February 15, 2021 14:42
@davidpatrick davidpatrick merged commit 2408cac into auth0:master Feb 23, 2021
davidpatrick pushed a commit that referenced this pull request Feb 23, 2021
@okko @davidpatrick
Add alg to SigningKey types (#220)
bd4be6a 
Co-authored-by: David Patrick <david.patrick@auth0.com>
# Conflicts:
#	index.d.ts
@davidpatrick davidpatrick added this to the 1.x.x milestone Feb 24, 2021
This was referenced Mar 12, 2021
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.12.3
Development

Successfully merging this pull request may close these issues.

client.getSigningKey returns .alg but the typing is missing alg
2 participants
@okko @davidpatrick