Fixing proxy on Axios #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default proxy option on Axios does not work. Using http-proxy-agent to handle proxied requests
davidpatrick
force-pushed
the
axios-proxy
branch
from
adf57db
to
673f7e8
Compare
stevehobbsdev
approved these changes
Sep 22, 2020
|
Thanks ! Looking forward to test in the next stable version ! |
Merged
|
This "fix" currently breaks everything as it moves "https-proxy-agent" to dev even though it gets used in the code. So that should get added again as a regular dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default proxy option on Axios does not work. Using http-proxy-agent to handle proxied requests
Testing
Improved proxy testing. No longer using nock, creating actual proxy server to fully test the request is being properly proxied.
Fixes #144