Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add promisified methods to JwksClient #161

Merged
merged 7 commits into from
Aug 12, 2020
Merged

Add promisified methods to JwksClient #161

merged 7 commits into from
Aug 12, 2020

Conversation

jimmyjames
Copy link
Contributor

Description

As raised in #76, this library should support methods that return Promises. This change adds new promisified equivalents for JwksClient, suffixed with Async:

  • getKeysAsync()
  • getSigningKeysAsync()
  • getSigningKeyAsync(kid)

This change:

  • Adds no additional dependencies
  • Changes no existing APIs
  • Makes no breaking changes, so can be released in a new minor version to the 1.x version

References

#76

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@jimmyjames jimmyjames added this to the v1-Next milestone Aug 11, 2020
@jimmyjames jimmyjames marked this pull request as ready for review August 11, 2020 22:49
@jimmyjames jimmyjames requested a review from a team August 11, 2020 22:49
davidpatrick
davidpatrick approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@davidpatrick davidpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 🎉 🎉

@davidpatrick davidpatrick merged commit e8196c9 into master Aug 12, 2020
@davidpatrick davidpatrick deleted the promisfy branch August 12, 2020 14:00
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.9.0 Aug 18, 2020
mwgamble pushed a commit to mwgamble/node-jwks-rsa that referenced this pull request Aug 19, 2020
Add missing async methods to Typescript type definitions
a36ab22 
These methods were added by auth0#161, but the PR did not include an update
to the matching Typescript type definitions. Without this update, these
new methods are unusable in Typescript projects.
@mwgamble mwgamble mentioned this pull request Aug 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimmyjames @davidpatrick @lbalmaceda