Skip to content

Commit

Permalink
This was a wrong test thrown off by salesforce/tough-cookie#240
Browse files Browse the repository at this point in the history
  • Loading branch information
adamjmcgrath committed Jun 14, 2023
1 parent fab6609 commit ce406af
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/auth0-session/transient-store.test.ts
Expand Up @@ -83,7 +83,7 @@ describe('TransientStore', () => {
expect(cookie?.secure).toBeFalsy();
});

it('should set SameSite=None, Secure=False for fallback cookie by default for http', async () => {
it('should not set SameSite and set Secure=False for fallback cookie by default for http', async () => {
const baseURL: string = await setup(
defaultConfig,
(req: NodeRequest, res: NodeResponse) => {
Expand All @@ -96,9 +96,8 @@ describe('TransientStore', () => {
const { value } = await get(baseURL, '/', { cookieJar });
const fallbackCookie = getCookie('_test_key', cookieJar, baseURL);
expect(value).toEqual(expect.any(String));
// TODO: figure out why this is sameSite 'none' (and why it's passing in main)
expect(fallbackCookie).toMatchObject({
sameSite: 'none',
sameSite: undefined,
secure: false,
httpOnly: true
});
Expand Down

0 comments on commit ce406af

Please sign in to comment.